Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module/apmhttp: support ELASTIC_APM_IGNORE_URLS #158

Merged
merged 1 commit into from
Jul 31, 2018

Conversation

axw
Copy link
Member

@axw axw commented Jul 31, 2018

Add support for ignoring requests with URLs matching the
regular expression specified in ELASTIC_APM_IGNORE_URLS.
Ignore requests are executed as normal, they just won't
be reported to Elastic APM.

Closes #154

@axw axw force-pushed the config-ignore-urls branch 2 times, most recently from d2e6343 to 3717af3 Compare July 31, 2018 06:35
Add support for ignoring requests with URLs matching the
regular expression specified in ELASTIC_APM_IGNORE_URLS.
Ignore requests are executed as normal, they just won't
be reported to Elastic APM.
@axw axw force-pushed the config-ignore-urls branch from 3717af3 to a5718c6 Compare July 31, 2018 06:35
@codecov-io
Copy link

codecov-io commented Jul 31, 2018

Codecov Report

Merging #158 into master will decrease coverage by 0.41%.
The diff coverage is 45.9%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #158      +/-   ##
==========================================
- Coverage   77.54%   77.12%   -0.42%     
==========================================
  Files          69       70       +1     
  Lines        3945     3992      +47     
==========================================
+ Hits         3059     3079      +20     
- Misses        668      696      +28     
+ Partials      218      217       -1
Impacted Files Coverage Δ
module/apmhttp/client.go 73.33% <100%> (ø) ⬆️
module/apmhttprouter/handler.go 63.41% <25%> (-8.02%) ⬇️
module/apmgin/middleware.go 67.12% <40%> (-3.65%) ⬇️
module/apmgorilla/middleware.go 73.33% <44.44%> (-13.04%) ⬇️
module/apmhttp/ignorer.go 47.05% <47.05%> (ø)
module/apmhttp/handler.go 66.07% <50%> (-0.6%) ⬇️
module/apmecho/middleware.go 85.24% <57.14%> (-6.92%) ⬇️
tracer.go 84.92% <0%> (+0.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d464f3d...a5718c6. Read the comment docs.

@axw axw merged commit 2717dc2 into elastic:master Jul 31, 2018
@axw axw deleted the config-ignore-urls branch July 31, 2018 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants