-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to microsoft/mssqldb package #1569
Conversation
5660b20
to
53b397c
Compare
@@ -46,7 +46,7 @@ func DriverName(d driver.Driver) string { | |||
return "postgresql" | |||
} | |||
|
|||
if strings.HasPrefix(t.PkgPath(), "github.com/denisenkom/go-mssqldb") { | |||
if strings.HasPrefix(t.PkgPath(), "github.com/microsoft/go-mssqldb") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should either support the old prefix or drop support for the old repo and release a new minor version (e.g. 2.5.0 ?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Supporting the old prefix is tricky, as the only way we could do it is with two different driver names, which would be strange, as folks not using our instrumentation will not use the name we set here.
So I think releasing a minor version is what we need here.
run docs-build |
Hello guys, thank you for the switch to microsoft package!
Here is how I init my db instance:
|
We should update the documentation to add the sqlserver option in the driver list |
The denisenkom/go-mssqldb explicitly says in its readme:
So this PR switches our use of that module for the official one from Microsoft.