-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenTelemetry metrics exporter #1407
Conversation
Re: CI test failures on Go 1.15, 1.16 and 1.17. Otel follows the Golang release policy:
Which means it only support 1.19 and 1.20, and has therefore started using generics, making it impossible to use this version with any Go < 1.18. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Just a couple of comments.
Signed-off-by: dmathieu <[email protected]>
Signed-off-by: dmathieu <[email protected]>
Signed-off-by: dmathieu <[email protected]>
Signed-off-by: dmathieu <[email protected]>
Signed-off-by: dmathieu <[email protected]>
Signed-off-by: dmathieu <[email protected]>
Signed-off-by: dmathieu <[email protected]>
Signed-off-by: dmathieu <[email protected]>
Signed-off-by: dmathieu <[email protected]>
Signed-off-by: dmathieu <[email protected]>
Signed-off-by: dmathieu <[email protected]>
Signed-off-by: dmathieu <[email protected]>
Signed-off-by: dmathieu <[email protected]>
Signed-off-by: dmathieu <[email protected]>
Signed-off-by: dmathieu <[email protected]>
Signed-off-by: dmathieu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dmathieu great work, thank you. We just need to update the module major version suffixes, otherwise this is good to merge.
We can update the code later based on the outcome of the spec discussion about default bounds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR is setting up an OpenTelemetry metrics exporter, based on the specification in elastic/apm#742.