Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: default to custom for empty transaction and span types #1272

Merged
merged 3 commits into from
Jul 27, 2022
Merged

fix: default to custom for empty transaction and span types #1272

merged 3 commits into from
Jul 27, 2022

Commits on Jul 25, 2022

  1. fix: default to custom for empty transaction and span types 

    According to the spec:

If no transaction.type or span.type is provided or the value
is an empty string, the agent needs to set a default value
custom.

Add test to assert the behaviour is compliant to the spec.
    @kruskall
    kruskall committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    58fbbad View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2022

  1. fix: set default type at the end of the span/transaction

    @kruskall
    kruskall committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    5c5f0ed View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2022

  1. Merge branch 'main' into fix/empty-transaction-span-type

    @kruskall
    kruskall authored Jul 27, 2022
    Configuration menu
    Copy the full SHA
    9b67612 View commit details
    Browse the repository at this point in the history