Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stacktrace: fixes for goimports and inlining #127

Merged
merged 2 commits into from
Jun 27, 2018
Merged

Conversation

axw
Copy link
Member

@axw axw commented Jun 27, 2018

goimports formats differently depending on the
go version. Change how we initialise the radix
tree to fix this, while also reducing source
code size.

Update AppendCallerFrames to take a maximum number
of frames to append. Multiple frames may share a
PC, so it is not enough to just supply the callers
if we want to limit the output. If the supplied
count is negative, return all frames as before.

@axw axw changed the title stacktrace: fix goimports formatting stacktrace: fixes for goimports and inlining Jun 27, 2018
@axw axw force-pushed the fix-goimports branch from 6e1d16e to eb965d6 Compare June 27, 2018 02:43
@codecov-io
Copy link

codecov-io commented Jun 27, 2018

Codecov Report

Merging #127 into master will decrease coverage by 16.53%.
The diff coverage is 90%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #127       +/-   ##
===========================================
- Coverage   75.54%   59.01%   -16.54%     
===========================================
  Files          60       75       +15     
  Lines        3108     4028      +920     
===========================================
+ Hits         2348     2377       +29     
- Misses        577     1467      +890     
- Partials      183      184        +1
Impacted Files Coverage Δ
stacktrace/library.go 90% <100%> (+3.33%) ⬆️
error.go 73.2% <100%> (ø) ⬆️
stacktrace/stacktrace.go 77.61% <75%> (ø) ⬆️
utils_other.go 100% <0%> (ø)
transport/transporttest/recorder.go 0% <0%> (ø)
internal/pretty/pretty.go 0% <0%> (ø)
internal/apmdebug/debug.go 20% <0%> (ø)
internal/krtext/indent.go 0% <0%> (ø)
internal/krtext/wrap.go 0% <0%> (ø)
transport/transporttest/chan.go 0% <0%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9918f8c...df9ddf0. Read the comment docs.

axw added 2 commits June 27, 2018 11:05
goimports formats differently depending on the
go version. Change how we initialise the radix
tree to fix this, while also reducing source
code size.
Update AppendCallerFrames to take a maximum number
of frames to append. Multiple frames may share a
PC, so it is not enough to just supply the callers
if we want to limit the output. If the supplied
count is negative, return all frames as before.
@axw axw force-pushed the fix-goimports branch from eb965d6 to df9ddf0 Compare June 27, 2018 03:05
@axw axw merged commit fb3d6b5 into elastic:master Jun 27, 2018
@axw axw deleted the fix-goimports branch June 27, 2018 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants