Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable same kind, enable exact match compression by default #1256

Merged
merged 2 commits into from
Jun 1, 2022

Conversation

lahsivjar
Copy link
Contributor

@lahsivjar lahsivjar commented Jun 1, 2022

As per the updated span compression specs:

  1. Disables same kind compression by default
  2. Enable exact match compression by default

Closes #1229

@lahsivjar lahsivjar requested a review from a team June 1, 2022 04:35
@apmmachine
Copy link
Contributor

apmmachine commented Jun 1, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-01T06:23:24.501+0000

  • Duration: 80 min 38 sec

Test stats 🧪

Test Results
Failed 0
Passed 7372
Skipped 174
Total 7546

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@apmmachine
Copy link
Contributor

apmmachine commented Jun 1, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (59/59) 💚
Files 99.346% (152/153) 👍
Classes 96.812% (334/345) 👍
Methods 90.445% (956/1057) 👍 0.095
Lines 82.644% (11066/13390) 👍
Conditionals 100.0% (0/0) 💚

Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

span_test.go Show resolved Hide resolved
@lahsivjar lahsivjar enabled auto-merge (squash) June 1, 2022 06:28
@lahsivjar lahsivjar merged commit 9a7a606 into elastic:main Jun 1, 2022
@lahsivjar lahsivjar deleted the 1229_compression branch June 1, 2022 08:02
gregkalapos added a commit to gregkalapos/apm-agent-go that referenced this pull request Jan 30, 2023
gregkalapos added a commit to gregkalapos/apm-agent-go that referenced this pull request Mar 29, 2023
gregkalapos added a commit to gregkalapos/apm-agent-go that referenced this pull request Mar 29, 2023
Update doc to changes in elastic#1256

Signed-off-by: Greg Kalapos <[email protected]>
gregkalapos added a commit to gregkalapos/apm-agent-go that referenced this pull request Mar 30, 2023
Update doc to changes in elastic#1256

Signed-off-by: Greg Kalapos <[email protected]>
gregkalapos added a commit to gregkalapos/apm-agent-go that referenced this pull request Mar 30, 2023
Update doc to changes in elastic#1256

Signed-off-by: Greg Kalapos <[email protected]>
gregkalapos added a commit to gregkalapos/apm-agent-go that referenced this pull request Mar 30, 2023
Update doc to changes in elastic#1256

Signed-off-by: Greg Kalapos <[email protected]>
gregkalapos added a commit to gregkalapos/apm-agent-go that referenced this pull request Mar 30, 2023
Update doc to changes in elastic#1256

Signed-off-by: Greg Kalapos <[email protected]>
gregkalapos added a commit that referenced this pull request Mar 30, 2023
Update doc to changes in #1256

Signed-off-by: Greg Kalapos <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[META 619] Change default behavior for span compression and dropping of spans
4 participants