Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apmgrpc): wrap the server-stream with transaction-ctx #1151

Merged

Conversation

bendiktv2
Copy link
Contributor

This allows the handler to retrieve the transaction from it's context, to e.g. create spans.

This closes #1148

This allows the handler to retrieve the transaction from it's context, to e.g. create spans.
@apmmachine
Copy link
Contributor

apmmachine commented Nov 4, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-11-15T12:04:44.067+0000

  • Duration: 33 min 46 sec

  • Commit: 53ec384

Test stats 🧪

Test Results
Failed 0
Passed 11645
Skipped 268
Total 11913

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@stuartnelson3 stuartnelson3 requested a review from axw November 5, 2021 09:26
Copy link
Contributor

@stuartnelson3 stuartnelson3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I'll wait for @axw for final approval. He'll be back next week.

Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! The approach looks good, I'd just like to avoid the dependency please.

module/apmgrpc/server.go Outdated Show resolved Hide resolved
Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@axw
Copy link
Member

axw commented Nov 15, 2021

/test

1 similar comment
@axw
Copy link
Member

axw commented Nov 15, 2021

/test

@axw axw enabled auto-merge (squash) November 15, 2021 12:04
@axw axw disabled auto-merge November 16, 2021 01:11
@axw axw merged commit 98763b8 into elastic:master Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve gRPC Stream Interceptor
4 participants