-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(apmgrpc): wrap the server-stream with transaction-ctx #1151
feat(apmgrpc): wrap the server-stream with transaction-ctx #1151
Conversation
This allows the handler to retrieve the transaction from it's context, to e.g. create spans.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but I'll wait for @axw for final approval. He'll be back next week.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! The approach looks good, I'd just like to avoid the dependency please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you :)
/test |
1 similar comment
/test |
This allows the handler to retrieve the transaction from it's context, to e.g. create spans.
This closes #1148