transaction: Collect stats about dropped spans #1132
Conversation
Modifies the span timing reporting function to collect statistics about dropped spans when they exceed the `transaction_max_spans`. Each dropped span is now aggregated under the `transaction.dropped_spans_stats` array with a maximum count of items of `128`. Each dropped span is aggregated on 4 dimensions: `outcome`. `subtype`, `type` and `destination_service_resource` and report 2 metrics, their `duration.sum.us` and the `count` for each of the aggregated dropped spans. Signed-off-by: Marc Lopez Rubio <[email protected]>
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
Signed-off-by: Marc Lopez Rubio <[email protected]>
|
We may remove the "type" and "subtype" dimensions since they're not sure on the |
Signed-off-by: Marc Lopez Rubio <[email protected]>
Signed-off-by: Marc Lopez Rubio <[email protected]>
Signed-off-by: Marc Lopez Rubio <[email protected]>
| @@ -510,7 +510,7 @@ func spanSelfTimeMetrics(txName, txType, spanType, spanSubtype string, count int | |||
| }, | |||
| Samples: map[string]model.Metric{ | |||
| "span.self_time.count": {Value: float64(count)}, | |||
| "span.self_time.sum.us": {Value: sum.Seconds() * 1000000}, | |||
| "span.self_time.sum.us": {Value: float64(sum) / 1e3}, | |||
There was a problem hiding this comment.
I had to change this since there was a case where 510000 turned into 510.00000000000006 due to the time.Duration.Seconds() logic. In any case, this should be the same as the other operation, perhaps a little more efficient, since we're only doing 1 division.
There was a problem hiding this comment.
this is fine, it's just test code anyway
Signed-off-by: Marc Lopez Rubio <[email protected]>
| @@ -510,7 +510,7 @@ func spanSelfTimeMetrics(txName, txType, spanType, spanSubtype string, count int | |||
| }, | |||
| Samples: map[string]model.Metric{ | |||
| "span.self_time.count": {Value: float64(count)}, | |||
| "span.self_time.sum.us": {Value: sum.Seconds() * 1000000}, | |||
| "span.self_time.sum.us": {Value: float64(sum) / 1e3}, | |||
There was a problem hiding this comment.
this is fine, it's just test code anyway
Signed-off-by: Marc Lopez Rubio <[email protected]>
Description
Modifies the span timing reporting function to collect statistics about
dropped spans when they exceed the
transaction_max_spans. Each droppedspan is now aggregated under the
transaction.dropped_spans_statsarraywith a maximum count of items of
128.Each dropped span is aggregated on:
destination_service_resourceandoutcomereporting 2 metrics, theirduration.sum.usand thecountfor each of the aggregated dropped spans.
TODO
Related issues
Closes #1113