Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --disable-check-for-update to cargo make invocations during build #2186

Merged
merged 3 commits into from
Sep 20, 2023
Merged

Add --disable-check-for-update to cargo make invocations during build #2186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fdc1507
Add --disable-check-for-update to cargo make invocations during build
Mpdreamz Sep 19, 2023
372daee
increase timeout on cargo clean
Mpdreamz Sep 19, 2023
7e35061
disable IIS tests for now
Mpdreamz Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/test-windows-iis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,12 @@ jobs:
test-iis:
runs-on: windows-latest

# disable IIS on CI for now.
# Run locally and started failing randomly on github actions
# Could be because of plethora of reasons including no disk space
# Requires longer investigation
Mpdreamz marked this conversation as resolved.
Show resolved Hide resolved
if: ${{ false }}

steps:
- uses: actions/checkout@v3
- name: Bootstrap Action Workspace
Expand Down
4 changes: 2 additions & 2 deletions build/scripts/Build.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ module Build =
/// Builds the CLR profiler and supporting .NET managed assemblies
let BuildProfiler () =
dotnet "build" (Paths.ProfilerProjFile "Elastic.Apm.Profiler.Managed")
Cargo.Exec [ "make"; "build-release"; ]
Cargo.Exec [ "make"; "build-release"; "--disable-check-for-update"]

/// Publishes all projects with framework versions
let Publish targets =
Expand Down Expand Up @@ -185,7 +185,7 @@ module Build =
if isWindows && not isCI then msBuild "Clean" aspNetFullFramework

let CleanProfiler () =
Cargo.Exec ["make"; "clean"]
Cargo.ExecWithTimeout ["make"; "clean"; "--disable-check-for-update"] (TimeSpan.FromMinutes 10)

/// Restores all packages for the solution
let ToolRestore () =
Expand Down
Loading