Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker listen to /var/run/docker.sock #157

Merged
merged 1 commit into from
May 5, 2022

Conversation

obierlaire
Copy link
Contributor

According to ECE installer and our test suite, we should default to /var/run/docker.sock instead of /run/docker.sock.

NB: on some OS, we force docker.service to listen on /run/docker.sock while docker.socket service listen on /var/run/docker.sock

@obierlaire obierlaire marked this pull request as ready for review May 4, 2022 18:00
@obierlaire
Copy link
Contributor Author

Tested on all OSes and does not make thing worse (aka ECE is well bootstrapping)

Copy link
Contributor

@alpar-t alpar-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving since this bring the playbook in line with the docs so it makes sense, but note that it seems that /run is the one we should be using according to the FHS

@obierlaire obierlaire merged commit a041141 into elastic:master May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants