Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support of SLES 15 #156

Merged
merged 5 commits into from
May 10, 2022
Merged

Support of SLES 15 #156

merged 5 commits into from
May 10, 2022

Conversation

obierlaire
Copy link
Contributor

Supporting SLES 15 and working around #155

ydubreuil
ydubreuil approved these changes May 4, 2022
View reviewed changes
Copy link
Member

@ydubreuil ydubreuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left one comment about how the playbook work around the issue caused by nscd.

tasks/base/SLES-15/install_docker.yml Outdated
args:
warn: false

- name: disable nscd (otherwise container will ignore their /etc/hosts)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to remove the package instead of only disabling the daemon. That will open less opportunities for problems.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea

tasks/base/SLES-12/install_docker.yml Outdated
args:
warn: false

- name: disable nscd (otherwise container will ignore their /etc/hosts)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to remove the package instead of only disabling the daemon. That will open less opportunities for problems.

@obierlaire obierlaire mentioned this pull request May 4, 2022
Open
@obierlaire obierlaire merged commit fda73b0 into elastic:master May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alpar-t alpar-t alpar-t approved these changes

@artemnikitin artemnikitin artemnikitin approved these changes

@ydubreuil ydubreuil ydubreuil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@obierlaire @ydubreuil @artemnikitin @alpar-t