Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If not peering from eicommon environment, set no ingress rules. #93

Merged
merged 1 commit into from
Oct 15, 2024
Merged

If not peering from eicommon environment, set no ingress rules. #93

merged 1 commit into from
Oct 15, 2024

Conversation

hkobayash
Copy link
Contributor

Even if ei_sg_ids or ei_cidrs are empty, it will still work.

@hkobayash hkobayash merged commit 7a13e0d into master Oct 15, 2024
@hkobayash hkobayash deleted the dev/support_non_peering_environments branch October 15, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryotana ryotana ryotana approved these changes

@watanabe-kyohei watanabe-kyohei watanabe-kyohei approved these changes

@limitusus limitusus Awaiting requested review from limitusus

@wittro wittro Awaiting requested review from wittro

@hoshihaya hoshihaya Awaiting requested review from hoshihaya

@yumaatt yumaatt Awaiting requested review from yumaatt

@kei500 kei500 Awaiting requested review from kei500

@dekachiri dekachiri Awaiting requested review from dekachiri

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hkobayash @watanabe-kyohei @ryotana