Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify private-s3-bucket lifecycle arguments #84

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

kei500
Copy link
Contributor

@kei500 kei500 commented Apr 5, 2024

I've fixed private-s3-bucket module to simplify its lifecycle arguments by:

  • set AbortIncompleteMultipartUpload action as first rule and remove abort_incomplete_multipart_upload_days argument.
  • set default value of some arguments by using optional method.

Copy link
Contributor

@wittro wittro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆒

@kei500 kei500 merged commit e1f2930 into master Apr 8, 2024
@kei500 kei500 deleted the feature/private-s3-bucket-lifecycle-optional branch April 8, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants