Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[POC] init impl to add datasource service/client lifecycle #19
[POC] init impl to add datasource service/client lifecycle #19
Changes from 1 commit
282e578
1a8e74b
2567a2e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@noCharger do we have action item for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed offline, we can use https://github.com/elastic-analytics/OpenSearch-Dashboards/blob/db8c74eacd7a78830f[…]c/plugins/credential_management/server/crypto/cli/crypto_cli.ts for the end-to-end PoC. Support
decrypt(authId: string)
is a non-blocking follow-up.Also from the principle of single responsibility, fetch credential using saved object cli and decrypt with cryto cli could be decoupled. Let's name the function as
fetch_and_decrypt(id: string)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
opensearch-project#1926
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@noCharger Made the change to first fetch encrypted password in
opensearch_data_service
, and then use existingCrptoCLI -> decrypt()
function for the end-to-end use case to run. Any subsequent change will be posted in separate PR. But I don't think a functionality ofgetCredentialById
is a multi-responsibility. We can discuss moreThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check the opensearch js client, see if it can keep the connection until being explicitly closed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/elastic/elasticsearch-js/blob/4def742e4774dba44f31b8e1701345a8c29870ee/lib/Connection.js#L59-L63
keep-alive
is default to true inClientOptions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how is this field being used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's used in the Compatibility check(that I commented out for now). Compatibility checks happen constantly until "this.stop" is called (which it will be called in
stop()
stage in our case)