Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MD][Cred Mgr]PoC delete credentials #10

Merged
merged 1 commit into from
Jul 11, 2022
Merged

[MD][Cred Mgr]PoC delete credentials #10

merged 1 commit into from
Jul 11, 2022

Conversation

noCharger
Copy link
Collaborator

@noCharger noCharger commented Jul 11, 2022 •
edited
Loading

Description

  1. PoC delete credentials

Screen Shot 2022-07-11 at 12 59 36 PM

  1. Resolve some UI feedbacks in [MD][Cred mngment] - PoC Create credential #9

Issue

  • Add Table route

@noCharger noCharger merged commit 2fa92e0 into 2.x Jul 11, 2022
@noCharger noCharger deleted the feature-edit-credential branch July 11, 2022 20:57
@kristenTian
Copy link

Can we follow the convention and add title filed to credential saved object mapping?

This can enable some logic and code reusability. Thanks.

@noCharger noCharger mentioned this pull request Jul 12, 2022
Merged
@noCharger
Copy link
Collaborator Author

noCharger commented Jul 12, 2022 •
edited
Loading

Can we follow the convention and add title filed to credential saved object mapping?

This can enable some logic and code reusability. Thanks.

Updated #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seraphjiang seraphjiang seraphjiang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noCharger @kristenTian @seraphjiang