Link libssl and libz statically
#546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is only used by the HTTP client of `meilisearch_sdk`, i.e. to communicate with Meilisearch. In most instances, Meili runs on the same machine without HTTPS, so this is basically never used. In particular, Tobira cannot listen on HTTPS directly (you should use a reverse proxy for that). And to communicate with Opencast, rustls is used. Ideally, meilisearch_sdk would also use rustls and in the future we can do that. But for now, we want to statically link libssl to make it easier to deploy Tobira. The main argument against static linking is that an administrator cannot deploy libssl security updates without updating Tobira. Yes, but that's already true for 99% of Tobira's dependencies. So just dynamically linking this one library isn't making a big difference. Also, as mentioned above, libssl is not even used in most situations. And if it's used, there is no user interaction.
See last commit for reasoning. libz is only used by the build dependency `built` and meilisearch_sdk at runtime. So the same reasoning applies basically.
|
🚀 This PR was deployed at https://pr546.tobira.opencast.org. The deployment will be updated whenever someone pushes onto this PR's branch. |
LukasKalbertodt
added a commit
to LukasKalbertodt/tobira
that referenced
this pull request
Dec 12, 2024
In elan-ev#546 I configured dependencies to avoid dynamically linking libssl and libz. I just checked again after the Meili update and noticed that those library are again linked dynamically. I think this has to do with me adding `reqwest` as dependencies without disabling default features. With this commit, libssl and libz are again not dynamically linked.
LukasKalbertodt
added a commit
to LukasKalbertodt/tobira
that referenced
this pull request
Dec 12, 2024
In elan-ev#546 I configured dependencies to avoid dynamically linking libssl and libz. I just checked again after the Meili update and noticed that those library are again linked dynamically. I think this has to do with me adding `reqwest` as dependencies without disabling default features. With this commit, libssl and libz are again not dynamically linked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC #537
See first commit for reasoning. This leaves Tobira only linking to "libstd libraries" basically.