Add support for aws eks get-token authenticator and IAM role ARN
#993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cPu1
force-pushed
the
authenticator-role-arn-788-749
branch
from
cc73132 to
8abab85
Compare
|
Thanks @cPu1! I'll review in detail next week, I think overall this is in the right direction :) |
cPu1
force-pushed
the
authenticator-role-arn-788-749
branch
from
8abab85 to
05abb47
Compare
|
LGTM |
martina-if
previously approved these changes
Jul 8, 2019
errordeveloper
suggested changes
Jul 17, 2019
There was a problem hiding this comment.
Code looks good, thanks! Please make sure to add the docs. I've merged #999 just now also.
errordeveloper
force-pushed
the
authenticator-role-arn-788-749
branch
from
05abb47 to
95bfb55
Compare
errordeveloper
approved these changes
Jul 18, 2019
toabctl
added a commit
to toabctl/amazon-eks-ami
that referenced
this pull request
Apr 22, 2021
…#446)" This reintroduces the switch to use "aws eks get-token" instead of the aws-iam-authenticator. The reason (see [0]) why that switch got reverted was, that eksctl wasn't able to handle the situation where aws-iam-authenticator was not there. But that changed (see [1] and [2]) so switching to aws-cli for getting a token should be good now. This reverts commit d6e021b. [0] awslabs#446 [1] eksctl-io/eksctl#788 [2] eksctl-io/eksctl#993
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for:
aws eks get-tokenas the authenticator for signing requests if neitheraws-iam-authenticatornorheptio-authenticator-awsis available inPATH.aws-iam-authenticatorandaws eks get-token, toeksctl create clusterandeksctl utils write-kubeconfigvia flag--authenticator-role-arn.Support for
aws eks get-tokenwas added recently, so presence ofawsinPATHdoes not implyaws eks get-tokenwould work. Instead of inspecting the version or checking if it supportsget-token, we simply use it as a fallback if other authenticators aren't available inPATHandawsis available (which is also the motivation for usingaws eks get-tokensince most users would already haveawsinstalled).Checklist
make build)make test)README.md, andexamplesdirectory)