Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --config-file to eksctl drain ng #741

Merged
merged 2 commits into from
Apr 17, 2019
Merged

Add --config-file to eksctl drain ng #741

merged 2 commits into from
Apr 17, 2019

Conversation

errordeveloper
Copy link
Contributor

@errordeveloper errordeveloper commented Apr 16, 2019 •
edited
Loading

Description

Closes #737.

Checklist

  • Code compiles correctly (i.e make build)
  • All unit tests passing (i.e. make test)
  • All integration tests passing (i.e. make integration-test)

@errordeveloper errordeveloper marked this pull request as ready for review April 16, 2019 17:40
@errordeveloper
Update flags for eksctl drain ng
cc77e72 
- mirror what `eksctl delete ng` does, i.e.:
  - add functionality to drain multiple nodegroups with `--config-file`
  - and `--include`/`--exclude` filters
    - add `--only-missing` (inverted fitering)
    - add `--approve` (only with `--config-file`)
@errordeveloper errordeveloper merged commit d187db2 into master Apr 17, 2019
@errordeveloper errordeveloper deleted the fix-737 branch April 17, 2019 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rndstr rndstr Awaiting requested review from rndstr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

drain ng should have same flags as delete ng
1 participant
@errordeveloper