Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade aws-node to v1.4.1 #736

Merged
merged 3 commits into from
May 7, 2019
Merged

Upgrade aws-node to v1.4.1 #736

merged 3 commits into from
May 7, 2019

Conversation

errordeveloper
Copy link
Contributor

@errordeveloper errordeveloper commented Apr 16, 2019 •
edited
Loading

Description

Closes #734.

Checklist

  • Code compiles correctly (i.e make build)
  • Added tests that cover your change (if possible)
  • All unit tests passing (i.e. make test)

@errordeveloper
Copy link
Contributor Author

@tiffanyfay @christopherhein FYI.

@errordeveloper
Copy link
Contributor Author

errordeveloper commented Apr 16, 2019 •
edited
Loading

Looks like image is not yet available in eu-west-2.

  Warning  Failed                 5s (x3 over 43s)   kubelet, ip-192-168-62-107.eu-west-2.compute.internal  Failed to pull image "602401143452.dkr.ecr.eu-west-2.amazonaws.com/amazon-k8s-cni:v1.4.0": rpc error: code = Unknown desc = Error response from daemon: manifest for 602401143452.dkr.ecr.eu-west-2.amazonaws.com/amazon-k8s-cni:v1.4.0 not found

@errordeveloper errordeveloper mentioned this pull request Apr 16, 2019
Closed
@christopherhein
Copy link
Contributor

Awesome! we’re not making 1.4 default in EKS for another 1-2 weeks so good to get this primed.

@errordeveloper
Copy link
Contributor Author

we’re not making 1.4 default in EKS for another 1-2 weeks so good to get this primed

Is this information available in a place where we can track it?

@StevenACoffman
Copy link
Contributor

StevenACoffman commented Apr 18, 2019 •
edited
Loading

ref aws/containers-roadmap#149

@StevenACoffman StevenACoffman mentioned this pull request Apr 18, 2019
Closed
@StevenACoffman StevenACoffman mentioned this pull request Apr 29, 2019
Closed
@errordeveloper errordeveloper force-pushed the fix-734 branch 2 times, most recently from 5d0ce40 to 312ba0c Compare May 1, 2019 13:50
@errordeveloper
Copy link
Contributor Author

errordeveloper commented May 1, 2019 •
edited
Loading

@christopherhein @tiffanyfay any updates on 1.4 rollout? I've rebased this.

@errordeveloper
Copy link
Contributor Author

I've tested and it works now.

@StevenACoffman
Copy link
Contributor

1.4.1 just released, btw.

@errordeveloper errordeveloper changed the title Upgrade aws-node to v1.4.0 Upgrade aws-node to v1.4.1 May 7, 2019
@errordeveloper
Make ekctl utils update-aws-node aware of Kubernetes version
ace29d3 
It needs to pick the right manifest based on the version used.
@errordeveloper errordeveloper merged commit 73cf28e into master May 7, 2019
@errordeveloper errordeveloper deleted the fix-734 branch May 7, 2019 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StevenACoffman StevenACoffman StevenACoffman left review comments

Assignees

@christopherhein christopherhein

@tiffanyfay tiffanyfay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use latest aws-node add-on
4 participants
@errordeveloper @christopherhein @StevenACoffman @tiffanyfay