adding EKS Account ID for security measures when using for AMIs

[christopherhein]

Signed-off-by: Christopher Hein [email protected]

Description

closes #732

This checks the right Account ID for AL2 AMIs so that they always come from the EKS team.

Checklist

• Code compiles correctly (i.e make build)
• All unit tests passing (i.e. make test)
• All integration tests passing (i.e. make integration-test)

[errordeveloper]

It would be also great to not spoil the coverage, this package has pretty good coverage and we should keep it that way. So please take a look if you can add a meaningful test for this!

[christopherhein]

Once tests pass let me know what you think @errordeveloper

[christopherhein]

@errordeveloper everything looks good now on this if you get a second to merge.

[martina-if]

LGTM

[nrdlngr]

Any update on this?

[errordeveloper]

This is better, just a few somewhat cosmetic things please! :)

[errordeveloper]

This a little too optimistic, we should check if the key exists, so we don't panic if it doesn't.

[errordeveloper]

Please move the look-up into the caller, and the map declaration should live in the same file also:

https://github.com/weaveworks/eksctl/blob/3d20b573fcc5b495ba6729ba4affdc25a285639a/pkg/ami/auto_resolver.go#L50

[errordeveloper]

We should be able to include this in the next release, but due to undergoing API changes, we cannot cut it before all of milestone issues are closed, as we are half-way-through.

[errordeveloper]

@christopherhein I'll have to finish this up myself, as we are looking to cut 0.1.30 today.