-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rework stack management #695
Conversation
3b490b0
to
fc1ba94
Compare
@rndstr would you mind to take a look at this please? |
Still need to rewrite the unit tests. |
59858bf
to
cbcb386
Compare
I think there is a bug, like a possible race condition... I'll need to investigate, perhaps unit tests will show. |
f84c72f
to
44bc37e
Compare
@martina-if thanks for spotting the race condition! As I mentioned, I was able to reproduce it with unit tests. I've fixed it a we have quite a few tests now. This PR is in a pretty good shape to merge next week :) |
44bc37e
to
090b122
Compare
Looks like we cannot use
|
e7b5aca
to
7f33b11
Compare
050384a
to
86a94f0
Compare
- more visibility into what task manager does - print clear descriptions of what is being done - enable addition of `--dry-run` to every command - cleaner main functions for create and delete commands - more general abstraction for tasks - expose all common operations through functions - remove special purpose taks handler functions
86a94f0
to
cac01aa
Compare
cac01aa
to
6a10163
Compare
NodeExpandVolume no-op for raw block
Description
Checklist
make build
)make test
)make integration-test
)README.md
, andexamples
directory)