Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip diff tests on Windows #486

Merged
merged 1 commit into from
Jan 31, 2019
Merged

Skip diff tests on Windows #486

merged 1 commit into from
Jan 31, 2019

Conversation

errordeveloper
Copy link
Contributor

Description

As discussed in #449.

Checklist

  • Code compiles correctly (i.e make build)
  • All tests passing (i.e. make test)

@errordeveloper
Copy link
Contributor Author

@dcherman did you have a chance to take this for a quick test?

@dcherman
Copy link
Contributor

@errordeveloper I pulled down that branch and gave it a test run this morning. It definitely gets by the diff tests now, so that is good to go. It still hangs on the lint part of it, but I haven't done a lot of triage on that yet. One thing that I did note is that unless I'm mistaken, it's linting all of the vendor folder which takes a significant amount of time and is also 3rd party code.

@errordeveloper
Copy link
Contributor Author

...it's linting all of the vendor folder which takes a significant amount of time and is also 3rd party code.

That's not supposed to happen, see linter config:

https://github.com/weaveworks/eksctl/blob/380d6fc5a8fc3ef8939e9d0a7486044ec2e6599d/.gometalinter.json#L1-L16

I'll merge this, and we can move on with build instructions.

@errordeveloper errordeveloper merged commit c2ad8a8 into master Jan 31, 2019
@errordeveloper errordeveloper deleted the fix-windows-build branch January 31, 2019 08:22
torredil pushed a commit to torredil/eksctl that referenced this pull request May 20, 2022
docs/README: add missing "--namespace" flag to "helm" command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants