Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use *bool to make defaulting controllable #467

Merged
merged 1 commit into from
Jan 25, 2019
Merged

Use *bool to make defaulting controllable #467

merged 1 commit into from
Jan 25, 2019

Conversation

errordeveloper
Copy link
Contributor

Description

Fixes #466.

Checklist

  • Code compiles correctly (i.e make build)
  • All tests passing (i.e. make test)

@errordeveloper errordeveloper changed the title Use *bool for all fields that where we need to control defaulting Use *bool to make defaulting controllable Jan 25, 2019
@errordeveloper errordeveloper merged commit b01cc6b into master Jan 25, 2019
@errordeveloper errordeveloper deleted the bool-fields branch January 25, 2019 16:41
@errordeveloper errordeveloper mentioned this pull request Jan 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlespiau dlespiau dlespiau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@errordeveloper @dlespiau