-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue preventing to create single-AZ nodegroups #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
errordeveloper
force-pushed
the
fix-nodegroup-az-selection
branch
from
January 15, 2019 08:33
87ceb6f
to
8274973
Compare
|
errordeveloper
changed the title
WIP: Fix nodegroup AZ selection
Fix nodegroup AZ selection
Jan 15, 2019
errordeveloper
changed the title
Fix nodegroup AZ selection
Fix issue preventing to create single-AZ nodegroups
Jan 15, 2019
This allows us to also obtain public and private subnets separately, so that we have complete set of identifiers that would be of use to create build the nodegroup stack.
errordeveloper
force-pushed
the
fix-nodegroup-az-selection
branch
from
January 15, 2019 09:08
8274973
to
191bb1a
Compare
dlespiau
approved these changes
Jan 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
\o/
thanks @dlespiau! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make sure to fetch public and private subnet IDs when getting all VPC info. This was address in #
Fixes #432. This is an improvement on what #429, but it uses CloudFormation stack outputs, since there we get subnet IDs by topologies easily.
Checklist
make build
)make test
)