feat: Nodegroup as a resource #369

mumoshu · 2018-12-22T10:08:32Z

eksctl now allows you to manage any number of nodegroups other than the initial nodegroup.

Changes:

eksctl create nodegroup --cluster CLUSTER_NAME [NODEGROUP_NAME] is added

Creates an additional nodegroup.
The nodegroup name is randomly generated when omitted.
eksctl get nodegroup --cluster CLUSTER_NAME is added

Lists all the nodegroups including the initial one and the additional ones.
eksctl delete nodegroup --cluster CLUSTER_NAME NODEGROUP_NAME is added

Deletes a nodegroup by name.
eksctl create cluster has been changed to accept an optional --nodegroup NODEGROUP_NAME that specifies the nodegroup name.
eksctl delete cluster CLUSTER_NAME has been changed to recursively delete all the nodegroups including additional ones.
eksctl scale nodegroup --cluster CLUSTER_NAME NODEGROUP_NAME has been changed to accept the target nodegroup name as the second argument

Checklist:

Code compiles correctly (i.e make build)
Added tests that cover your change (if possible)
All tests passing (i.e. make test)
Added/modified documentation as required (such as the README)
Added yourself to the humans.txt file

Acknowledgements:

This is a successor of #281 and #332.

All the original credits goes to Richard Case [email protected] who has started #281. Thanks a lot, Richard!

Signed-off-by: Yusuke Kuoka [email protected]

errordeveloper

Thanks for wrapping this up @mumoshu! I'd love to get it in ASAP, and due to holidays and timezones I'm going to address my review comments myself.

README.md

pkg/cfn/builder/nodegroup.go

pkg/ctl/create/cluster.go

pkg/ctl/delete/delete.go

pkg/ctl/get/get.go

pkg/ctl/get/get.go.orig

pkg/ctl/scale/nodegroup.go.orig

pkg/eks/api/api.go

pkg/ctl/cmdutils/nodegroup.go

pkg/cfn/manager/nodegroup.go

pkg/ctl/scale/nodegroup.go

pkg/eks/nodegroup.go

errordeveloper · 2018-12-24T14:16:35Z

I've started making changes, but looks like I might now be able to finish this today and need to switch to doing something else. I will continue after the holidays, i.e. most likely on Friday.

mumoshu · 2018-12-25T03:57:37Z

@errordeveloper Thanks for your efforts! I've added small commits hoping they help you focus on bigger things.

Also - I started getting 404 errors from the weaveworks/eksctl project in CircleCI due to unknown reason. Perhaps someone in your org. made the whole CircleCI org private, by any chance?

The build seems broken seeing the status check, but is passing on my machine.

mumoshu · 2018-12-26T02:40:36Z

Please cherry-pick #375 to fix Circle builds. See #374 for more context.

mumoshu · 2018-12-26T03:18:10Z

look delete cluster code path - there seems to be an infinite loop

@errordeveloper I've reproduced and fixed this in 19f9f1f

mumoshu · 2018-12-26T03:22:42Z

fix name of initial nodegroup

I believe this has been fixed in da00fc9, in case that's what you meant.

Sorry for leaving many mistakes but this should be good to go now(again).

errordeveloper · 2018-12-27T18:43:13Z

My final TODOs:

`eksctl` now allows you to manage any number of nodegroups other than the initial nodegroup. Changes: - `eksctl create nodegroup --cluster CLUSTER_NAME [NODEGROUP_NAME]` is added Creates an additional nodegroup. The nodegroup name is randomly generated when omitted. - `eksctl get nodegroup --cluster CLUSTER_NAME` is added Lists all the nodegroups including the initial one and the additional ones. - `eksctl delete nodegroup --cluster CLUSTER_NAME NODEGROUP_NAME` is added Deletes a nodegroup by name. - `eksctl create cluster` has been changed to accept an optional `--nodegroup NODEGROUP_NAME` that specifies the nodegroup name. - `eksctl delete cluster CLUSTER_NAME` has been changed to recursively delete all the nodegroups including additional ones. - `eksctl scale nodegroup --cluster CLUSTER_NAME NODEGROUP_NAME` has been changed to accept the target nodegroup name as the second argument Checklist: - [x] Code compiles correctly (i.e `make build`) - [x] Added tests that cover your change (if possible) - [x] All tests passing (i.e. `make test`) - Added/modified documentation as required (such as the README) - Added yourself to the `humans.txt` file Acknowledgements: This is a successor of eksctl-io#281 and eksctl-io#332. All the original credits goes to Richard Case <[email protected]> who has started eksctl-io#281. Thanks a lot, Richard! Signed-off-by: Yusuke Kuoka <[email protected]>

errordeveloper · 2018-12-28T11:54:33Z

pkg/cfn/manager/api.go

+}
+
+// BlockingWaitDeleteStack kills a stack by name and waits for DELETED status
+func (c *StackCollection) BlockingWaitDeleteStack(name string) error {


We add Blocking to the name of the old function, because that's what it is actually. We keep using it where it was used previously, but use new non-blocking version above when we need to delete all nodegroups in parallel and run a task for each of the nodegroups.

pkg/cfn/manager/api.go

- move name generator functions into one file make usage consistent - review stack manager code - make examples in docs more consistent - update output message formatting, improve consistency - update some usage messages, move more flags into cmdutils - refactor `ctl.GetCredentials` - refactor stack listers - do not reset tags when scaling nodegroup

- ensure CGO is always off and netgo is always on - add musl-dev (somehow cgo still gets dragged in) - add .dockerignore files

errordeveloper · 2018-12-28T14:03:02Z

🎉

kylemclaren · 2018-12-29T11:18:50Z

Been waiting on this feature, thanks to all who made it happen 🎉

enable users to set ec2-endpoint for nonstandard regions

mumoshu force-pushed the nodegroup-as-resource branch from 5b62bb7 to 867c73f Compare December 22, 2018 10:11

errordeveloper mentioned this pull request Dec 22, 2018

drain nodegroup on deletion #370

Closed

errordeveloper requested review from errordeveloper and richardcase December 22, 2018 11:06

errordeveloper reviewed Dec 24, 2018

View reviewed changes

errordeveloper force-pushed the nodegroup-as-resource branch from 867c73f to 07a5cc2 Compare December 24, 2018 12:54

errordeveloper reviewed Dec 24, 2018

View reviewed changes

pkg/cfn/manager/nodegroup.go Outdated Show resolved Hide resolved

errordeveloper reviewed Dec 24, 2018

View reviewed changes

pkg/ctl/scale/nodegroup.go Outdated Show resolved Hide resolved

errordeveloper reviewed Dec 24, 2018

View reviewed changes

pkg/eks/nodegroup.go Show resolved Hide resolved

errordeveloper changed the title ~~feat: Nodegroup as a resource~~ WIP: feat: Nodegroup as a resource Dec 24, 2018

This comment has been minimized.

Sign in to view

errordeveloper force-pushed the nodegroup-as-resource branch 3 times, most recently from f65c323 to 8010128 Compare December 27, 2018 16:48

This comment has been minimized.

Sign in to view

errordeveloper force-pushed the nodegroup-as-resource branch from 8010128 to 4002579 Compare December 27, 2018 18:30

errordeveloper force-pushed the nodegroup-as-resource branch from 4002579 to 4ad2d88 Compare December 27, 2018 18:44

errordeveloper force-pushed the nodegroup-as-resource branch 3 times, most recently from 67a91a8 to 24d6f7f Compare December 27, 2018 20:27

errordeveloper force-pushed the nodegroup-as-resource branch from 24d6f7f to 51ddf93 Compare December 27, 2018 20:40

errordeveloper changed the title ~~WIP: feat: Nodegroup as a resource~~ feat: Nodegroup as a resource Dec 28, 2018

errordeveloper force-pushed the nodegroup-as-resource branch 3 times, most recently from 626c72b to 8022c72 Compare December 28, 2018 11:51

errordeveloper reviewed Dec 28, 2018

View reviewed changes

pkg/cfn/manager/api.go Outdated Show resolved Hide resolved

errordeveloper added 2 commits December 28, 2018 12:24

Ensure tests fail when integration tests don't compile

c356a9c

errordeveloper force-pushed the nodegroup-as-resource branch from 8022c72 to c356a9c Compare December 28, 2018 12:24

errordeveloper previously approved these changes Dec 28, 2018

View reviewed changes

errordeveloper dismissed their stale review via 7f6deee December 28, 2018 13:07

Build improvements

015e273

- ensure CGO is always off and netgo is always on - add musl-dev (somehow cgo still gets dragged in) - add .dockerignore files

errordeveloper force-pushed the nodegroup-as-resource branch from 7f6deee to 015e273 Compare December 28, 2018 13:53

errordeveloper approved these changes Dec 28, 2018

View reviewed changes

errordeveloper merged commit c0e754c into eksctl-io:master Dec 28, 2018

errordeveloper mentioned this pull request Dec 29, 2018

How to upgrade existing worker node group? #357

Closed

errordeveloper mentioned this pull request Jan 3, 2019

allow creating clusters without initial nodegroup #376

Closed

buzzsurfr mentioned this pull request Jan 22, 2019

Nodegroup name changed aws-samples/eks-workshop#259

Closed

mumoshu mentioned this pull request Feb 12, 2019

Declarative way to add/delete nodegroups #462

Closed

torredil pushed a commit to torredil/eksctl that referenced this pull request May 20, 2022

Merge pull request eksctl-io#369 from amdonov/custom-ec2-endpoint

e4569c3

enable users to set ec2-endpoint for nonstandard regions

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Nodegroup as a resource #369

feat: Nodegroup as a resource #369

mumoshu commented Dec 22, 2018

errordeveloper left a comment

errordeveloper commented Dec 24, 2018

This comment has been minimized.

mumoshu commented Dec 25, 2018 •

edited

Loading

mumoshu commented Dec 26, 2018

mumoshu commented Dec 26, 2018

mumoshu commented Dec 26, 2018

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

errordeveloper commented Dec 27, 2018 •

edited

Loading

errordeveloper Dec 28, 2018

errordeveloper commented Dec 28, 2018

kylemclaren commented Dec 29, 2018

feat: Nodegroup as a resource #369

feat: Nodegroup as a resource #369

Conversation

mumoshu commented Dec 22, 2018

errordeveloper left a comment

Choose a reason for hiding this comment

errordeveloper commented Dec 24, 2018

This comment has been minimized.

mumoshu commented Dec 25, 2018 • edited Loading

mumoshu commented Dec 26, 2018

mumoshu commented Dec 26, 2018

mumoshu commented Dec 26, 2018

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

errordeveloper commented Dec 27, 2018 • edited Loading

errordeveloper Dec 28, 2018

Choose a reason for hiding this comment

errordeveloper commented Dec 28, 2018

kylemclaren commented Dec 29, 2018

mumoshu commented Dec 25, 2018 •

edited

Loading

errordeveloper commented Dec 27, 2018 •

edited

Loading