Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some refactoring #356

Merged
merged 2 commits into from
Dec 18, 2018
Merged

Some refactoring #356

merged 2 commits into from
Dec 18, 2018

Conversation

errordeveloper
Copy link
Contributor

Description

  • move Version out of ClusterProvider into ClusterMeta-only
  • consistent naming of region constants

Checklist

  • Code compiles correctly (i.e make build)
  • All tests passing (i.e. make test)

@errordeveloper
Consistent naming for region constants
74752c8
@errordeveloper
Remove Version from ClusterProvider
f8c0ad9 
Version is part of config of individual cluster, this interface is
unaware of such details. And instance of a provider can used to
manage multiple cluster under one AWS account, in a single region.
@errordeveloper errordeveloper merged commit ff01af9 into master Dec 18, 2018
@errordeveloper errordeveloper deleted the some-refactoring branch December 18, 2018 15:48
torredil pushed a commit to torredil/eksctl that referenced this pull request May 20, 2022
Merge pull request eksctl-io#356 from leakingtapan/changelog
be783b2 
Update CHANGELOG and image tag for release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@errordeveloper