Add integration tests and update cleanup #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 14, 2018 01:16
Add the BDD integration tests for the deletion of the cluster created during the clust creation test. It only checks for the deletion of stacks and eks clusters. Issue #208
Adding an integration test for listing the active clusters, ensuring the previously created cluster is listed and exit code != 0. Issue #208
Updating the names in the integration test cleanup step to the latest naming scheme. Issue #208
errordeveloper
approved these changes
Oct 15, 2018
There was a problem hiding this comment.
@Lazyshot thanks a lot for thin PR! The changes look good. I'll run it manually now, then merge.
|
Indeed, great addition @Lazyshot, thanks 🎉 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The initial issue #208 covers updating the stack names in the cleanup, but @richardcase mentioned the lack of coverage in the
get clusteranddelete clustercommands.These tests were added and the stack names updated.
Checklist
make build)make test)humans.txtfile