Add some tests #121
Merged
Add some tests #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@richardcase I would be curious to see how we would test 3435db8, I think it maybe an easier place to start (maybe along with SSH key importer), as these are simple and well isolated APIs. Also we will probably stop using EKS API directly sooner or later in favour of CloudFormation. |
Added an initial couple of tests to prove that mocking of the AWS services is possible.
Added Ginkgo to structure the tests better. Added input validation to the mocked services in the tests.
|
@richardcase please review, and merge if you are happy with my changes, I think this is all in a good shape now and we can iterate on actual tests in separate PRs! 🎉 |
|
@errordeveloper - i think it would be fairly easy to create tests around SelectAvailabilityZones. I will give it a go. |
errordeveloper
approved these changes
Jul 17, 2018
richardcase
commented
Jul 18, 2018
|
|
||
| import _ "github.com/vektra/mockery" | ||
|
|
||
| //go:generate mockery -dir=../../../vendor/github.com/aws/aws-sdk-go/service/cloudformation/cloudformationiface -name=CloudFormationAPI -output=./ |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| } | ||
|
|
||
| func (m MockProvider) EKS() eksiface.EKSAPI { return m.eks } | ||
| func (m MockProvider) mockEKS() *mocks.EKSAPI { return m.EKS().(*mocks.EKSAPI) } |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
torredil
pushed a commit
to torredil/eksctl
that referenced
this pull request
May 20, 2022
Add CHANGELOG for v0.1.0 alpha release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show the work-in-progress for adding tests to eksctl. Its currently pretty rough.
Issue #46