-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Placement Group support when creating EKS cluster #479
Comments
I suggested in #198 that when creating node group we could provide an AWS Launch Template ID as the basis for the node group instances. Then many advanced options like Place Groups could be passed through to the ASG, with having to code every single AWS instance option into
|
@whereisaaron Thanks. Expose Launch Templates makes sense what if I just want to have a clean cluster without making any other changes? That may not be easy in this way. |
Hi @Jeffwan, specifying a Launch Template would be entirely optional. For standard clusters The option to provide your own custom Launch Template would allow you to customize a great many advanced setting, including placement groups. If |
Does anyone have an example or documentation on how to do this? |
We have just merged Launch Template changes (#743), which are expected to land in the next release (potentially due in before end of this week). |
Has #743 landed already? Any examples on how to use launch templates along with placement groups available would be really helpful |
Hi @dalbhanj , eksctl already uses launch templates but it doesn't support placement groups yet. We will update this issue when it lands :) (hopefully soon) |
Any update on a placement group example? |
@martina-if any update on placement-groups via eksctl? is there any workaround if not ready yet? |
Hi @mbagliojr @nigesh-pugazhendhi , unfortunately this work has been down-prioritized lately but pull requests are welcome :) |
@Jeffwan We're looking at supporting this by specifying a launch template in the nodegroup config, where options like Placement group can be defined. For the case of placement groups, would it be sufficient to be able to supply a launch template ID (for a launch template created outside of eksctl, where the placement group would be referenced) or is it important to be able to define the launch template referencing the placement group inline in the config? I.e.:
or
|
@michaelbeaumont Thanks for coming back on this. Either pass an existing placement for that node group (ASG) to use or create a new placement group if it doesn't exists. I think following is more aligned with users's requirement
|
@michaelbeaumont Any updates on this feature request? |
@Jeffwan The current plan for the first iteration is the basic version, to add a new option to
where the placement group has to exist already. |
Talked with @michaelbeaumont offline. |
Bump Go to 1.14.1
Before creating a feature request, please search existing feature requests to see if you find a similar one. If there is a similar feature request please up-vote it and/or add your comments to it instead
I didn't find it's there, please correct me if you already have it.
Why do you want this feature?
Lots of machine learning workloads requires low latency network support and users like to leverage placement group feature to achieve that. (I think single AZ is supported and we'd like to move further)
What feature/behavior/change do you want?
A clear and concise description of the change you would like to see in eksctl.
Do not hesitate, when appropriate, to share the exact commands or API you would like, and/or to share a diagram (e.g.: asciiflow.com): "a picture is worth a thousand words".
Let me know this this is reasonable and I can help on the implementation
The text was updated successfully, but these errors were encountered: