Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Fix for 3 vulnerabilities #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ekmixon
Copy link
Owner

@ekmixon ekmixon commented Feb 2, 2024

This PR was automatically created by Snyk using the credentials of a real user.


Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • package.json

Vulnerabilities that will be fixed

With an upgrade:
Severity Priority Score (*) Issue Breaking Change Exploit Maturity
high severity 696/1000
Why? Proof of Concept exploit, Has a fix available, CVSS 7.5
Regular Expression Denial of Service (ReDoS)
SNYK-JS-ANSIREGEX-1583908
Yes Proof of Concept
high severity 681/1000
Why? Proof of Concept exploit, Has a fix available, CVSS 7.2
Command Injection
SNYK-JS-LODASHTEMPLATE-1088054
Yes Proof of Concept
high severity 589/1000
Why? Has a fix available, CVSS 7.5
Denial of Service (DoS)
SNYK-JS-TRIMNEWLINES-1298042
Yes No Known Exploit

(*) Note that the real score may have changed since the PR was raised.

Commit messages
Package name: gulp-angular-templatecache The new version differs by 82 commits.
  • 85733f6 Set 3.0.1
  • 032e71e Add contributor
  • a6ed3b5 Update to gulp-footer 2.1.0 (#180)
  • 6256844 Set 3.0.0
  • 4b92f3f Fix deprecated Buffer (#174)
  • 8d47008 Update to NodeJS 8 (#176)
  • 81e61fa Feature/update dependencies (#177)
  • 8e88c50 Bump version to 2.2.7
  • e63c7de Add contributors
  • 276f5c8 Add NodeJS 12 (#172)
  • 26ce3f7 fix: don't try to process directories (#145) (#171)
  • 0d7d6c2 Updated gulp-header to 2.0.7 (#170)
  • 7cf16e2 Bump version to 2.2.6
  • 648e80a Add contributor
  • 69f3bb7 Replaced uses of event-stream with direct dependencies (#168)
  • 4696789 Bump version to 2.2.5
  • c5abf0e Revert "Add trailing separator to file.base if not present (#165)"
  • a284cf7 Bump version to 2.2.4
  • 4149664 Add trailing separator to file.base if not present (#165)
  • af0f6ff Add contributor
  • 9289d8a Bump version to 2.2.3
  • 7ebfd8c Merge pull request #163 from miickel/add-node11-to-travis
  • a7b4d11 Add NodeJS 11
  • a9a745d Merge pull request #162 from dmellstrom/patch-1

See the full diff

Package name: gulp-filenames The new version differs by 19 commits.

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)
🦉 Command Injection

Micro-Learning Topic: OS command injection (Detected by phrase)

Matched on "Command Injection"

What is this? (2min video)

In many situations, applications will rely on OS provided functions, scripts, macros and utilities instead of reimplementing them in code. While functions would typically be accessed through a native interface library, the remaining three OS provided features will normally be invoked via the command line or launched as a process. If unsafe inputs are used to construct commands or arguments, it may allow arbitrary OS operations to be performed that can compromise the server.

Try a challenge in Secure Code Warrior

Helpful references
  • OWASP Command Injection - OWASP community page with comprehensive information about command injection, and links to various OWASP resources to help detect or prevent it.
  • OWASP testing for Command Injection - This article is focused on providing testing techniques for identifying command injection flaws in your applications

Micro-Learning Topic: Regular expression denial of service (Detected by phrase)

Matched on "Regular Expression Denial of Service"

What is this? (2min video)

Denial of Service (DoS) attacks caused by Regular Expression which causes the system to hang or cause them to work very slowly when attacker sends a well-crafted input(exponentially related to input size).Denial of service attacks significantly degrade the service quality experienced by legitimate users. These attacks introduce large response delays, excessive losses, and service interruptions, resulting in direct impact on availability.

Try a challenge in Secure Code Warrior

Micro-Learning Topic: Denial of service (Detected by phrase)

Matched on "Denial of Service"

The Denial of Service (DoS) attack is focused on making a resource (site, application, server) unavailable for the purpose it was designed. There are many ways to make a service unavailable for legitimate users by manipulating network packets, programming, logical, or resources handling vulnerabilities, among others. Source: https://www.owasp.org/index.php/Denial_of_Service

Try a challenge in Secure Code Warrior

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Enhancement

PR Summary: This PR is an automated enhancement to update vulnerable npm dependencies to fixed versions. It specifically upgrades 'gulp-angular-templatecache' and 'gulp-filenames' to address security vulnerabilities.

Decision: Comment

📝 Type: 'Enhancement' - not supported yet.
  • Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
✅ Small diff: the diff is small enough to approve with confidence.
No details provided.

General suggestions:

  • Ensure that the major version upgrades do not introduce breaking changes that could affect the build or runtime behavior of the project.
  • Review the release notes or change logs of the updated packages to understand the scope of changes and to identify any additional adjustments that might be necessary.
  • Consider verifying the compatibility of these upgrades with the rest of the project's dependencies to prevent any potential conflicts or issues.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@@ -13,11 +13,11 @@
"del": "~1.2.0",
"gulp": "~3.9.0",
"gulp-angular-filesort": "~1.1.1",
"gulp-angular-templatecache": "~1.6.0",
"gulp-angular-templatecache": "~3.0.1",
"gulp-autoprefixer": "~2.3.1",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (llm): The version of 'gulp-autoprefixer' remains unchanged. If the other package updates were part of a general dependency update, consider checking if there's also a newer version of 'gulp-autoprefixer' that could be beneficial.

@@ -13,11 +13,11 @@
"del": "~1.2.0",
"gulp": "~3.9.0",
"gulp-angular-filesort": "~1.1.1",
"gulp-angular-templatecache": "~1.6.0",
"gulp-angular-templatecache": "~3.0.1",
"gulp-autoprefixer": "~2.3.1",
"gulp-concat": "^2.6.0",
"gulp-csso": "~1.0.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (llm): Given the updates to other packages, it might be worth evaluating if 'gulp-csso' also has a newer version available that could provide performance improvements or bug fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants