Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for regional BAM re-alignment with bgzipped inputs: glia: out_of_range and tabix errors #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chapmanb
Copy link

Eric;
This fixes two issues I ran into while using glia for realignment included
called variants.

  • It avoid erroring out when tabix region retrieval has no variants. The current
    logic would fail both on tabix retrieval due to a return problem with vcflib
    (fixed at Complementary fix for glia regional realignment around variants vcflib/vcflib#28) and in regions which don't
    have any variants where setRegion returns false. The fix checks the logic but
    avoids erroring out, instead only iterating over variants if they are present.
  • Avoids std::out_of_range errors from referenceSequence.at(sp) when an
    alignment falls over the end of reference sequence. The fix counts these as
    mismatches.

Here's a small reproducible test case that triggers these errors.

wget https://github.com/chapmanb/bcbio.variation.plus/raw/master/test/data/ensemble/NA12878-10.bam
wget https://raw.github.com/chapmanb/bcbio.variation.plus/master/test/data/ensemble/chr10-start.fa
wget https://s3.amazonaws.com/chapmanb/union-10_250000_400000.vcf.gz
tabix -p vcf union-10_250000_400000.vcf.gz
samtools view -bu NA12878-10.bam | glia -d -Rr -w 1000 -S 200 -Q 200 -G 4 -f chr10-start.fa -v union-10_250000_400000.vcf.gz

Thanks again for this tool. I'm excited to have a minimal test case running with
it and looking forward to exploring more.

…ence sequence. Avoid erroring out when tabix region retrieval has no variants.
@ekg
Copy link
Owner

ekg commented Jan 31, 2014

Hi Brad,

In trying to run the test I hit a snag. The BAM file (https://github.com/chapmanb/bcbio.variation.plus/raw/master/test/data/ensemble/NA12878-10.bam) does not appear to exist, or the URL has changed. Could you please update this and I'll run the tests.

@chapmanb
Copy link
Author

Erik;
Sorry about this. I moved these over to another repository. The new wgets are:

wget https://github.com/chapmanb/bcbio.variation.recall/raw/master/test/data/ensemble/NA12878-10.bam
wget https://raw.github.com/chapmanb/bcbio.variation.recall/master/test/data/ensemble/chr10-start.fa

Please let me know if you run into anything else. Thanks much for looking at these.

@ekg
Copy link
Owner

ekg commented Jan 31, 2014

Great, I've just downloaded them.

On Fri, Jan 31, 2014 at 7:22 AM, Brad Chapman [email protected]:

Erik;
Sorry about this. I moved these over to another repository. The new wgets
are:

wget https://github.com/chapmanb/bcbio.variation.recall/raw/master/test/data/ensemble/NA12878-10.bam
wget https://raw.github.com/chapmanb/bcbio.variation.recall/master/test/data/ensemble/chr10-start.fa

Please let me know if you run into anything else. Thanks much for looking
at these.

Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-33789855
.

@yifangt
Copy link

yifangt commented Jul 9, 2017

I was wondering where the "fastq.h" header is or, it may not be needed?

@jollymrt
Copy link

jollymrt commented Aug 9, 2018

Hi Erik,

I am trying to run glia to realign a bam file around indels but getting the following error "Command not found : glia Did you mean ...."
how to resolve this issue. I am currently in glia directory and have run make and cmake on both bam and glia. I dont see any executable or dll files after running make. Can you please help.

Regards
Jolly

@ekg
Copy link
Owner

ekg commented Aug 10, 2018 via email

@jollymrt
Copy link

jollymrt commented Aug 13, 2018 via email

@ekg
Copy link
Owner

ekg commented Aug 14, 2018

@jollymrt let's continue this conversation here: vgteam/vg#1823

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants