Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to pass in an ISO "lastmod" string directly #9

Merged
merged 2 commits into from
Jun 2, 2014

Conversation

julianlam
Copy link
Contributor

Downstream: NodeBB/NodeBB#1578

Would like to pass in a parsed ISO string into the library, instead of having the library do it for me, so I added a new property, lastmodISO (I'd prefer lastmod myself, but in the interest of backwards compatibility, I called it lastmodISO instead)

Since I store my values in my db as unix timestamp in ms, it seems roundabout to:

  1. Convert ms to date object
  2. Parse date object into YYYY-MM-DD
  3. Pass that into your module and have it parsed back into a Date object
  4. Parsed back into YYYY-MM-DD again

So I'd like to just pass it in directly.

ekalinin added a commit that referenced this pull request Jun 2, 2014
Ability to pass in an ISO "lastmod" string directly
@ekalinin ekalinin merged commit c8bbbb8 into ekalinin:master Jun 2, 2014
@ekalinin
Copy link
Owner

ekalinin commented Jun 2, 2014

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants