For mozilla-mobile#11320 - Expose login autofill setting to beta dime…

…nsion
ekager · Jul 2, 2020 · 1381aec · 1381aec
1 parent ed3a80a
commit 1381aec
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 8 deletions.
diff --git a/app/src/geckoBeta/java/org/mozilla/fenix/engine/GeckoProvider.kt b/app/src/geckoBeta/java/org/mozilla/fenix/engine/GeckoProvider.kt
@@ -56,11 +56,7 @@ object GeckoProvider {
         }
 
         val geckoRuntime = GeckoRuntime.create(context, runtimeSettings)
-        // As a quick fix for #8967 we are conflating "should autofill" with "should save logins"
-        val loginStorageDelegate = GeckoLoginStorageDelegate(
-            storage,
-            { context.settings().shouldPromptToSaveLogins }
-        )
+        val loginStorageDelegate = GeckoLoginStorageDelegate(storage, { true })
         geckoRuntime.loginStorageDelegate = GeckoLoginDelegateWrapper(loginStorageDelegate)
 
         return geckoRuntime

diff --git a/app/src/main/java/org/mozilla/fenix/settings/logins/SavedLoginsAuthFragment.kt b/app/src/main/java/org/mozilla/fenix/settings/logins/SavedLoginsAuthFragment.kt
@@ -111,9 +111,6 @@ class SavedLoginsAuthFragment : PreferenceFragmentCompat(), AccountObserver {
         }
 
         requirePreference<SwitchPreference>(R.string.pref_key_autofill_logins).apply {
-            // The ability to toggle autofill on the engine is only available in Nightly currently
-            // See https://github.com/mozilla-mobile/fenix/issues/11320
-            isVisible = Config.channel.isNightlyOrDebug
             isChecked = context.settings().shouldAutofillLogins
             onPreferenceChangeListener = object : SharedPreferenceUpdater() {
                 override fun onPreferenceChange(preference: Preference, newValue: Any?): Boolean {