Skip to content

Commit

Permalink
netty: Remove Maven pom.properties from netty-shaded
Browse files Browse the repository at this point in the history
The pom.properties are apparently present to allow tooling to know what
Maven artifact cooresponds to a JAR, just by looking at the JAR. Since
we shade Netty, that produces inaccurate results. This was noticed in
in grpc#8077.
  • Loading branch information
ejona86 committed May 12, 2021
1 parent f049530 commit fefa57c
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions netty/shaded/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ shadowJar {
include(project(':grpc-netty'))
include(dependency('io.netty:'))
}
exclude 'META-INF/maven/**'
relocate 'io.grpc.netty', 'io.grpc.netty.shaded.io.grpc.netty'
relocate 'io.netty', 'io.grpc.netty.shaded.io.netty'
// We have to be careful with these replacements as they must not match any
Expand Down

0 comments on commit fefa57c

Please sign in to comment.