Proofs for JOSS #11
Merged
Proofs for JOSS #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
40 tasks
|
The proofs look good, thanks! I guess the second duplicate paragraph should be dropped. Okay, then we move on with the png format since reconverting to pdf could reduce the quality of the plot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are a couple of minor changes before final acceptance (JOSS doesn't have an external proof service). I recommend you give it a final read as well to be sure everything is fine before publication.
Preview here: https://res.cloudinary.com/hkvhhndao/image/upload/v1635157383/ndf8jrv9caupcb9jz23g.pdf
It would be amazing it you could also provide the figure as a pdf file instead of png. Don't worry if you can't, it's not such a big deal.
Related to openjournals/joss-reviews#3705.