Replace item.add_report_section() with long_repr.addsection() #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit cfedc4 does the reverse change and introduces the follwing bug. When used together with pytest junitxml plugin, the XML report does not contain the captured log output, since junit-xml does not know about the 'log' section. Also, with this change when a test fails we will see the logs only from the method that caused the failure, which means if a test failed in teardown phase we will not see logs from setup and call phases.
|
Build failed due to travis-ci currently been broken for pypy3 |
|
@eisensheng Could you please CR this PR or tell me to rebase PR #39 ? We really need a fix for this issue asap. |
|
@KKoukiou given that we merged pytest-dev/pytest#3156 into pytest, I guess that we can close this PR now, right? |
|
@Thisch I am closing, it's not relevant anymore. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit cfedc4 does the reverse change and introduces the following bug.
When used together with pytest junitxml option, the XML report does not
contain the captured log output, since junit-xml does not know about
the 'log' section.
I am not happy to post this change but this exact change was the one that broke
the logs of junitxml in first place. Please let me know what you think, or if you
can propose some other solution to this problem.
PR #39 addresses the same
issue so if you 're more comfortable with that I can rebase it and resend it.