Add proxy environment variables for npm postinstalls #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds http_proxy and https_proxy for npm runs, useful for npm postinstalls that use pure node <postinstall-script>.js to get the proxy without workarounds.
…proxy Those variables are needed for postinstall steps using node scripts
|
Any chance of getting this merged? |
|
@eirslett We would also and still appreciate the merge of this pull request. |
…or_npm_postinstalls
|
Sorry, looks like I botched the merge commit. There is a conflict against the master branch, could somebody please just pick up the code from this PR and make a new PR that works against the latest master? I'll promise to merge it! |
josehenriqueventura
added a commit
to josehenriqueventura/frontend-maven-plugin
that referenced
this pull request
Jun 28, 2023
|
@Cavva79 do you want to fix this PR? I should have asked it first. |
|
@josehenriqueventura go ahead. I am unable to fix it now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Found that for postinstall script, such openlayers 4 has, in a proxy network, this plugin is not passing right the proxy to node.js running the script.
Tests and Documentation
This fixes issue #657.
I tested and it seems to work with openlayers 4.6.4