fix: Added debounce delay for saving indexes #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joecrop
reviewed
Sep 30, 2022
joecrop
approved these changes
Sep 30, 2022
agg23
force-pushed
the
agg23/IndexSaveDebounce
branch
from
714d3bf to
dc0c7d1
Compare
|
@agg23 please rebase master here too and let's hope the pipeline passes on this. |
agg23
force-pushed
the
agg23/IndexSaveDebounce
branch
from
dc0c7d1 to
7c39f32
Compare
|
Hooray! The pipeline is running again! Looks like just a couple lint violations to resolve and we can get it merged. |
agg23
force-pushed
the
agg23/IndexSaveDebounce
branch
from
7c39f32 to
8dc0b30
Compare
agg23
force-pushed
the
agg23/IndexSaveDebounce
branch
from
8dc0b30 to
a417b5f
Compare
|
Sorry about that. I amended and force pushed, but didn't actually stage the change, so nothing actually changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The process of saving indexes to the workspace can be very slow, so performing this immediately on every change can freeze VSCode. This change adds a 10 second debounce period, where once no activity has occurred for 10 seconds, the save will begin.