fix(CI): replace yarn1 with npm when generating PDF docs #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odsod
reviewed
Jan 2, 2024
| return err | ||
| } | ||
| cmd := sg.Command(ctx, "yarn", "global", "add", "@kingjan1999/rapipdf-cli") | ||
| cmd := sg.Command(ctx, "npm", "--global", "install", "@kingjan1999/rapipdf-cli") |
There was a problem hiding this comment.
maybe add a comment here in case someone wonders why we use npm instead of yarn?
There was a problem hiding this comment.
Good catch, added it and referencing back to this PR too.
odsod
approved these changes
Jan 2, 2024
oscarmuhr
force-pushed
the
replace-yarn-for-npm
branch
2 times, most recently
from
7d1fb82
to
a377264
Compare
yarn1 appears to struggle with a dependency "string-width". To prevent CI from breaking, this PR replaces the use of yarn with npm when generating documentation PDF. Issue reported in multiple places such as: yarnpkg/yarn#8994 storybookjs/storybook#22431
oscarmuhr
force-pushed
the
replace-yarn-for-npm
branch
from
a377264
to
bedf865
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yarn1 appears to struggle with a dependency "string-width". To prevent CI from breaking, this PR replaces the use of yarn with npm when generating documentation PDF.
Issue reported in multiple places such as:
yarnpkg/yarn#8994
storybookjs/storybook#22431
TRA-772