Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ADR Process, inspired by the backstage ADR structure #205

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

quoral
Copy link
Contributor

@quoral quoral commented Oct 26, 2023

No description provided.

@quoral quoral requested a review from odsod as a code owner October 26, 2023 12:28
@quoral quoral requested a review from a team October 26, 2023 12:28
@quoral quoral force-pushed the adr-structure branch 4 times, most recently from 3b5aa9f to 99d8bd2 Compare October 26, 2023 12:34
@quoral quoral marked this pull request as draft October 26, 2023 12:37
@quoral
Copy link
Contributor Author

quoral commented Oct 26, 2023

Marking as draft until #206 is merged

@quoral quoral marked this pull request as ready for review October 27, 2023 06:46
@DavyJ0nes
Copy link

As this is a public repo, does it make sense to add this? I'm not against it but would mean some duplication and sanitisation of internal ADRs related to this repo.

@quoral
Copy link
Contributor Author

quoral commented Oct 27, 2023

@DavyJ0nes Correct, for we're specifically intending this to be ADRs related to the structure of the API, such as moving to V2 and how the choices made have an effect on the API structure. The idea came from @radhus and I personally really like it, to show a little bit more of a log of API Changes.

@quoral quoral merged commit 7bb13fb into master Oct 30, 2023
1 check passed
@quoral quoral deleted the adr-structure branch October 30, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants