Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(readme): updates readme to what worked on a "new" env #172

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

fnurk
Copy link
Contributor

@fnurk fnurk commented Aug 16, 2023

  • Removes deprecated(?) param in example config
  • changes install command to something that worked better, got 404's etc with current
  • removes generate param that made generation look in the example dir

@fnurk fnurk requested a review from a team as a code owner August 16, 2023 12:48
Copy link
Member

@radhus radhus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving the docs! ⭐ 🙏

I would prefer the public install URL, just to make it easily installable for users that don't want to follow the full example, but you are free to use my suggestion or not and merge anyway!

Maybe we can improve the docs later, making it clear when you need/want the repo cloned or not.

README.md Outdated Show resolved Hide resolved
Update README.md

Co-authored-by: William Johansson <[email protected]>

Removes
@fnurk fnurk merged commit 95374e3 into master Aug 17, 2023
1 check passed
@fnurk fnurk deleted the chore/update-readme branch August 17, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants