Error if \u{...} contains more than 6 hex digits

eilvelia · Oct 15, 2023 · 1e6d977 · 1e6d977
1 parent 211caf5
commit 1e6d977
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/lexer.ml b/src/lexer.ml
@@ -146,10 +146,11 @@ let rec string lexbuf =
   | "\\\"" -> Buffer.add_char string_buffer '"'; string lexbuf
   | "\\b" -> Buffer.add_char string_buffer '\b'; string lexbuf
   | "\\f" -> Buffer.add_char string_buffer '\012'; string lexbuf
-  | "\\u{", Rep (hex_digit, 1 .. 6), '}' ->
-    (* TODO: Disallow 7+ hex digits inside \u{...}? *)
+  | "\\u{", Plus hex_digit, '}' ->
     let code_str =
       Sedlexing.Utf8.sub_lexeme lexbuf 3 (Sedlexing.lexeme_length lexbuf - 4) in
+    if String.length code_str > 6 then
+      error "Invalid unicode code point, cannot contain more than 6 hex digits";
     let code = int_of_string @@ "0x" ^ code_str in
     if code > 0x10FFFF then
       error "Invalid unicode code point, cannot be greater than 10FFFF";

diff --git a/test/parse.ml b/test/parse.ml
@@ -378,9 +378,8 @@ let%test_module "strings" = (module struct
     [%expect {| (- (string "a _ a _ \226\129\159")) |}]
 
   let%expect_test "\\u{...} cannot contain more than 6 hex digits" =
-    (* TODO: Raise an error instead? *)
     test {|- "\u{1234567}"|};
-    [%expect {| (- (string "\\u{1234567}")) |}]
+    [%expect {| Error: :1:4-1:15: Invalid unicode code point, cannot contain more than 6 hex digits |}]
 
   let%expect_test "\\u{...} should not accept a > 0x10FFFF code point" =
     test {|- "\u{11FBBF} _"|};