Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Geocoding by Postal Codes for Germany #36

Closed
wants to merge 7 commits into from

Conversation

Detsieber
Copy link
Contributor

This solution is similar to the implementation of OK postcodes.

@Detsieber
Copy link
Contributor Author

@eileenmcnaughton : This commit is active for more than a year in a heavily used production environment (however, with Geocoder 1.7), and works well.

However, there are still a few issues:

  1. It ships together with the complete dataset of German postcodes. AFAIK there are no license issues for that - but if you would prefer to better load the data from an external source, this would still have to be implemented. (I would think it would be better to ship the data with the extension, or at least provide an easy way to load the data via the UI)
  2. no unit tests for German postcodes
  3. Update of Readme is missing

Please let me know what you need for merging this!

eileenmcnaughton added a commit that referenced this pull request Aug 6, 2023
provider for German postal codes (replaces #36)
@eileenmcnaughton
Copy link
Owner

This was replaced by #38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants