Skip to content

Commit

Permalink
Fixes breaking change done in net/url
Browse files Browse the repository at this point in the history
A change made to the net/url library in go 1.8 causes a panic when
starting kontrol:

panic: parse 127.0.0.1:4001: first path segment in URL cannot contain colon

This is caused by the fact that net/url no longer considers
"127.0.0.1:4001" a valid URL because the specification allows for dots
in the schema-part of the URL.

* golang/go#19297
  • Loading branch information
eikaas committed Jun 23, 2017
1 parent b14ee84 commit 9c1f065
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion kontrol/etcd.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ type Etcd struct {

func NewEtcd(machines []string, log kite.Logger) *Etcd {
if machines == nil || len(machines) == 0 {
machines = []string{"127.0.0.1:4001"}
machines = []string{"//127.0.0.1:4001"}
}

client := etcd.NewClient(machines)
Expand Down

0 comments on commit 9c1f065

Please sign in to comment.