forked from bisq-network/bisq
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix offer list filter bug due to direction flip
Respect the direction parmeter; do not give it meaning it does not have. If the user passes a 'buy' parameter, return buy offers. Do not misinterpret the param's intent. The direction parameter's value does not imply "buy=I'm a buyer, show me sell offers" or "sell=I'm a seller, show me buy offers". I got mixed up by looking at the UI. If I want to sell BTC, I click the SELL tab to view buy offers (maker as buyer). If I want to buy BTC, I click the BUY tab to view sell offers (maker as seller). This change also fixes an offer list sorting bug. The commit is in response to a requested changes in PR 4329: bisq-network#4329 (review)
- Loading branch information
1 parent
8bdbf79
commit 011f531
Showing
2 changed files
with
11 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters