Check for wrong venv path in cache #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eifinger
force-pushed
the
check_changed_venv_path
branch
from
8e7bb01 to
5d8f4e7
Compare
Commit c5f9dab overwrote the venv_path if it didn't match. Tests showed that some packages like certifi still relied on the hardcoded old path. Moreover it is not supported by rye to move venvs between paths and this action now complies with that rather than trying to be overly smart. The impact is a cache miss.
eifinger
force-pushed
the
check_changed_venv_path
branch
from
5d8f4e7 to
3ac4ae9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit c5f9dab overwrote the venv_path if it didn't match. Tests showed that some packages like certifi still relied on the hardcoded old path. Moreover it is not supported by rye to move venvs between paths and this action now complies with that rather than trying to be overly smart. The impact is a cache miss.