Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supress rye install log output #171

Merged
merged 1 commit into from
Feb 18, 2024
Merged

Supress rye install log output #171

merged 1 commit into from
Feb 18, 2024

Conversation

eifinger
Copy link
Owner

@eifinger eifinger commented Feb 18, 2024

rye uses whatthestell here to determine what shell is being used. This internally uses ps here.

My guess is that this prints error: process ID out of range when searching for the process which opened the shell in the current process "tree" because no shell is used when the rye self install command is executed by this typescript action.

Fixes: #169

rye uses [whatthestell](https://github.com/zekroTJA/whattheshell)
[here](https://github.com/mitsuhiko/rye/blob/d950ca25b032d59846b78aba3dfb1284e3d04505/rye/src/cli/rye.rs#L392)
to determine what shell is being used. This internally uses `ps`
[here](https://github.com/zekroTJA/whattheshell/blob/b6290f96b5638314ac4547def37fe35985831d5d/src/infer/unix.rs#L52).
My guess is that this prints`error: process ID out of range`
to stderr when searching for the process which opened the shell
in the current process "tree"
because no shell is used when the `rye self install`
command is executed by this typescript action.
@eifinger eifinger merged commit 0938193 into main Feb 18, 2024
38 checks passed
@eifinger eifinger added the enhancement New feature or request label Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Process ID out of range
1 participant