Skip to content

Commit

Permalink
arm: Use constants from sys/intr.h, not genassym
Browse files Browse the repository at this point in the history
We can now include sys/intr.h to get these constants rather than using
genassym. Opt for this simpler method.

PR:			283041
Sponsored by:		Netflix
Reviewed by:		mmel, andrew
Differential Revision:	https://reviews.freebsd.org/D47847
  • Loading branch information
bsdimp committed Dec 6, 2024
1 parent 7b16a4a commit d1e843b
Show file tree
Hide file tree
Showing 5 changed files with 2 additions and 11 deletions.
1 change: 1 addition & 0 deletions sys/arm/arm/exception.S
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@
#include <machine/armreg.h>
#include <machine/asmacros.h>
#include <machine/trap.h>
#include <sys/intr.h>

#ifdef KDTRACE_HOOKS
.bss
Expand Down
4 changes: 0 additions & 4 deletions sys/arm/arm/genassym.c
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,9 @@
*/

#include <sys/param.h>
#include <sys/bus.h>
#include <sys/cpuset.h>
#include <sys/systm.h>
#include <sys/assym.h>
#include <sys/intr.h>
#include <sys/pcpu.h>
#include <sys/proc.h>
#include <sys/mbuf.h>
Expand Down Expand Up @@ -131,8 +129,6 @@ ASSYM(DCACHE_LINE_MASK, offsetof(struct cpuinfo, dcache_line_mask));
ASSYM(ICACHE_LINE_SIZE, offsetof(struct cpuinfo, icache_line_size));
ASSYM(ICACHE_LINE_MASK, offsetof(struct cpuinfo, icache_line_mask));

ASSYM(INTR_ROOT_IRQ, INTR_ROOT_IRQ);

/*
* Emit the LOCORE_MAP_MB option as a #define only if the option was set.
*/
Expand Down
1 change: 1 addition & 0 deletions sys/arm64/arm64/exception.S
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
#include <machine/armreg.h>

#include "assym.inc"
#include <sys/intr.h>

.text

Expand Down
5 changes: 0 additions & 5 deletions sys/arm64/arm64/genassym.c
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,6 @@

#include <sys/param.h>
#include <sys/assym.h>
#include <sys/bus.h>
#include <sys/intr.h>
#include <sys/pcpu.h>
#include <sys/proc.h>

Expand Down Expand Up @@ -85,6 +83,3 @@ ASSYM(TF_ELR, offsetof(struct trapframe, tf_elr));
ASSYM(TF_SPSR, offsetof(struct trapframe, tf_spsr));
ASSYM(TF_ESR, offsetof(struct trapframe, tf_esr));
ASSYM(TF_X, offsetof(struct trapframe, tf_x));

ASSYM(INTR_ROOT_IRQ, INTR_ROOT_IRQ);
ASSYM(INTR_ROOT_FIQ, INTR_ROOT_FIQ);
2 changes: 0 additions & 2 deletions sys/riscv/riscv/genassym.c
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
#include <sys/proc.h>
#include <sys/mbuf.h>
#include <sys/vmmeter.h>
#include <sys/bus.h>
#include <vm/vm.h>
#include <vm/vm_param.h>
#include <vm/pmap.h>
Expand All @@ -51,7 +50,6 @@
#include <machine/proc.h>
#include <machine/cpufunc.h>
#include <machine/pte.h>
#include <machine/intr.h>
#include <machine/machdep.h>
#include <machine/vmparam.h>

Expand Down

0 comments on commit d1e843b

Please sign in to comment.