Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Respect user.id | name | displayName in traditional auth flow #31

Closed
Tracked by #30
egregors opened this issue Aug 18, 2024 · 1 comment
Closed
Tracked by #30
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@egregors
Copy link
Owner

egregors commented Aug 18, 2024

refs:

Goal flow should be look like:

  • BeginRegistration
    • client:
      • user provides user.name
    • back:
      • get user by username (to prevent duplicates)
      • create new user
        • generate user.id
        • put user.name
        • get options and session from webauthn
      • gen session key

Than means in the next version I'll drop GetOrCreateUser(userID string) User from the UserStore interface and replace it more usual GetUser(userName string) *User

We can also add some UI to define displayName. But idk do we really need it in _example. Will see.

@egregors egregors changed the title traditional way [BUG] Respect user.id | name | displayName in traditional auth flow Aug 18, 2024
@egregors egregors self-assigned this Aug 18, 2024
@egregors egregors added bug Something isn't working enhancement New feature or request labels Aug 18, 2024
egregors added a commit that referenced this issue Nov 13, 2024
@egregors
Copy link
Owner Author

rel: #36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant