Sandbox tenant data setup #600

varunreddy-egov · 2024-10-16T09:37:35Z

No description provided.

…ately

talele08 · 2024-10-16T09:41:08Z

core-services/default-data-handler/src/main/java/org/egov/handler/kafka/TenantConsumer.java

+
+        // Setting userInfo with UUID
+        User userInfo = User.builder()
+                .uuid("40dceade-992d-4a8f-8243-19dda76a4171")


Remove hardcoded uuid. Move to app props if required

talele08 · 2024-10-16T09:44:22Z

core-services/default-data-handler/src/main/java/org/egov/handler/util/HrmsUtil.java

+    public void upsertLocalization(TenantRequest tenantRequest) {
+
+        List<Message> messageList = generateDynamicMessage(tenantRequest);
+        tenantRequest.getRequestInfo().getUserInfo().setId(128L);


Remove hardcoding

talele08 · 2024-10-16T09:44:49Z

core-services/default-data-handler/src/main/java/org/egov/handler/util/HrmsUtil.java

+        this.serviceConfig = serviceConfig;
+    }
+
+    public void createHrmsEmployee(String HrmsRequest, String tenantId) {


Add comments on top of each functions

talele08 · 2024-10-16T09:46:26Z

core-services/default-data-handler/src/main/java/org/egov/handler/util/HrmsUtil.java

+
+        Tenant tenant = tenantRequest.getTenant();
+
+        String tenantCode = tenant != null && tenant.getCode() != null


Move null check to annotation based in POJO

talele08 · 2024-10-16T09:47:10Z

core-services/default-data-handler/src/main/java/org/egov/handler/util/HrmsUtil.java

+                ? tenant.getCode().toUpperCase().replace(".", "_")
+                : null;
+
+        String ulbKey = tenantCode != null


Remove if condition

talele08 · 2024-10-16T10:09:14Z

...services/default-data-handler/src/main/java/org/egov/handler/service/DataHandlerService.java

+        try {
+            emailBody = resource.getContentAsString(Charset.defaultCharset());
+        } catch (IOException e) {
+            throw new RuntimeException(e);


Throw custom exception

core-services/default-data-handler/src/main/java/org/egov/handler/kafka/TenantConsumer.java

core-services/default-data-handler/src/main/java/org/egov/handler/util/ElasticsearchUtil.java

talele08 · 2024-10-16T10:14:53Z

core-services/default-data-handler/src/main/java/org/egov/handler/util/MdmsV2Util.java

+		try {
+			restTemplate.postForObject(uri.toString(), mdmsRequest, MdmsResponseV2.class);
+		} catch (Exception e) {
+			if (e instanceof HttpClientErrorException httpException && (httpException.getStatusCode().value() == 400)) {


Follow standard error handling

…EASSIGN when a complaint is at PENDINGATLME.

This reverts commit b8c863a.

coderabbitai · 2024-10-24T04:24:24Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

varunreddy-egov and others added 30 commits August 23, 2024 16:15

Added default-data-handler consumer

e31345c

Added implementation of default data addition in localization

381ab1c

Added Dockerfile and migrate.sh in default-data-handler

8fcaf08

Modified pom.xml of default-data-handler

13805a4

Modified pom.xml of default-data-handler

db3c487

Modified application.properties of default-data-handler

087789b

Added user creation and user-otp in default-data-handler

9e17506

Added /defaultdata/setup API endpoint

8a85969

Modified validation logic

f04d87e

Added logic to create default tenant config for the target tenant

cf9d8fc

Added API to create default data for a module

95707f5

Modified the API response structure

510a188

Added logic to create default wf config for PGR

7a76a3f

Added logic to process egov-location.TenantBoundary schema code separ…

c8e129d

…ately

Enhanced error handling

8f133f1

Added uuid in userInfo

17161e9

Modified service layer

35f55bc

Added functionality to dynamically add tenant code

1429e92

add mdms data from json file for action-roles

7868856

Modified according to the changes in MDMS and localization

74b4d49

Modified how pgr and hrms schemacodes loaded

b9d98fd

Modified application.properties

83b0a81

Modified API payload

8fac806

Modified MDMS data create error handling

6343610

Modified localization module name

1c538c9

Modified egov-location.TenantBoundary schema code logic

6100f3f

Modified digit-tenants localization logic

803fcff

Modified to add default data of PGR & HRMS on tenant creation

4ac50f1

Added default employee creation

e500df3

Un-commented out the logic

6f2642a

Rishabh-egov and others added 12 commits October 4, 2024 16:52

Modified default employees name

8a7a699

Added default Dashbaord Data creation

ca015ad

Modified PgrIndexer.json

718bc22

Modified PgrWorkflowConfig.json

5dd2bfe

Modified default employee creation

9aa9ce8

Modified to add default data for more than one locale.

fa788af

Modified the PGR workflow config.

858e23c

Modified default employee creation

1d6d664

Modified default employee creation

034d67e

Added welcome email trigger

d953456

Added notification email topic

52bf8ba

Modified the default employee creation.

8f7e4f9

varunreddy-egov requested review from talele08, kavi-egov and shashwat-egov as code owners October 16, 2024 09:37

talele08 requested changes Oct 16, 2024

View reviewed changes

Rishabh-egov and others added 6 commits October 17, 2024 17:20

Fixed default employee creation issue

9331862

Added mobile number in HRMS

3d30b7d

Modified the workflow so that ASSIGNER can create a complaint.

b07344f

Modified the workflow so that RESOLVER can only perform RESOLVE and R…

f4e900d

…EASSIGN when a complaint is at PENDINGATLME.

Modified the boundary data creation logic.

b8c863a

Revert "Modified the boundary data creation logic."

31ae455

This reverts commit b8c863a.

Added default mobile number in default user creation

0dadad9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sandbox tenant data setup #600

Sandbox tenant data setup #600

varunreddy-egov commented Oct 16, 2024

talele08 Oct 16, 2024

talele08 Oct 16, 2024

talele08 Oct 16, 2024

talele08 Oct 16, 2024

talele08 Oct 16, 2024

talele08 Oct 16, 2024

talele08 Oct 16, 2024

coderabbitai bot commented Oct 24, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community


		Tenant tenant = tenantRequest.getTenant();

		String tenantCode = tenant != null && tenant.getCode() != null

Sandbox tenant data setup #600

Are you sure you want to change the base?

Sandbox tenant data setup #600

Conversation

varunreddy-egov commented Oct 16, 2024

talele08 Oct 16, 2024

Choose a reason for hiding this comment

talele08 Oct 16, 2024

Choose a reason for hiding this comment

talele08 Oct 16, 2024

Choose a reason for hiding this comment

talele08 Oct 16, 2024

Choose a reason for hiding this comment

talele08 Oct 16, 2024

Choose a reason for hiding this comment

talele08 Oct 16, 2024

Choose a reason for hiding this comment

talele08 Oct 16, 2024

Choose a reason for hiding this comment

coderabbitai bot commented Oct 24, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot commented Oct 24, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)